Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer

Steven Rostedt <[email protected]> writes:

> [...]
> +		 * [...] We don't need to grab
> +		 * any locks, we just keep trying until get all the
> +		 * calculations together in one state.
> +		 *
> +		 * In fact, we __cant__ grab any locks. This
> +		 * function is called from the latency_tracer which can
> +		 * be called anywhere. To grab any locks (including
> +		 * seq_locks) we risk putting ourselves into a deadlock.

Perhaps you could add a comment about why the loop, which appears
potentially infinite as written, avoids livelock.  (It looks rather
like a seqlock read loop.)

- FChE
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer
    • From: Steven Rostedt <[email protected]>

• References:
  • [PATCH RT 3/3] fix get_monotonic_cycles for latency tracer
    • From: Steven Rostedt <[email protected]>
  • [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer
    • From: Steven Rostedt <[email protected]>

• Prev by Date: Re: Linux-Kernel MAINTAINERS jffs-dev list entry alive?
• Next by Date: Re: [PATCH 1/1] hotplug cpu: migrate a task within its cpuset
• Previous by thread: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer
• Next by thread: Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]