On Fri, 24 Aug 2007 14:46:16 -0400
Jeff Dike <[email protected]> wrote:
> [ This looks non-urgent to me ]
>
> Without linux/pagemap.h, asm-generic/tlb.h is missing declarations of
> page_cache_release and release_pages.
>
> Signed-off-by: Jeff Dike <[email protected]>
> --
> include/asm-generic/tlb.h | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6.22/include/asm-generic/tlb.h
> ===================================================================
> --- linux-2.6.22.orig/include/asm-generic/tlb.h 2007-07-08 19:32:17.000000000 -0400
> +++ linux-2.6.22/include/asm-generic/tlb.h 2007-08-22 17:29:45.000000000 -0400
> @@ -13,6 +13,7 @@
> #ifndef _ASM_GENERIC__TLB_H
> #define _ASM_GENERIC__TLB_H
>
> +#include <linux/pagemap.h>
> #include <linux/swap.h>
> #include <asm/pgalloc.h>
> #include <asm/tlbflush.h>
This is worrisome. If you look at pagemap.h, it includes a pile of things
which could easily themsleves try to include tlb.h via some path or
another. I fear that this patch will cause explosions with some config
and/or architecture.
If you like, tlb.h is a low-level sort of thing whereas pagemap.h is a
higher-level VFS thing. It is more appropriate that pagemap.h be including
tlb.h.
So I think a better fix would be better, but I'm not able to suggest what,
as there is little detail about the failure here and I can find no mention
of page_cache_release and release_pages in asm-generic/tlb.h. Presumably
they're getting pulled in via some macro and then instantiated in some
inline function or something?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
