Re: [PATCH] Sort module list - use ppos instead of m->private

On Fri, 24 Aug 2007 11:39:33 -0400
Mathieu Desnoyers <[email protected]> wrote:

> Sort modules list - use ppos instead of m->private
> 
> When reading the data by small chunks (i.e. byte by byte), the index (ppos) is
> incremented by seq_read() directly and no "next" callback is called when going
> to the next module.
> 
> Therefore, use ppos instead of m->private to deal with the fact that this index
> is incremented directly to pass to the next module in seq_read() after the
> buffer has been emptied.

Confused.  What problem is this patch fixing?  I'm guessing that something
is going wrong when /proc/modules is read one-byte-at-a-time?

<tests that>

<nope>

Better changelogs, please.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Sort module list - use ppos instead of m->private
    • From: Mathieu Desnoyers <[email protected]>

• References:
  • [patch 0/2] Sorted seq_file
    • From: Mathieu Desnoyers <[email protected]>
  • [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators
    • From: Al Viro <[email protected]>
  • Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators
    • From: Al Viro <[email protected]>
  • [PATCH] Sort module list - use ppos instead of m->private
    • From: Mathieu Desnoyers <[email protected]>

• Prev by Date: Re: 2.6.23-rc3-mm1
• Next by Date: Re: Possible problems reading a DVD-RAM disc
• Previous by thread: [PATCH] Sort module list - use ppos instead of m->private
• Next by thread: Re: [PATCH] Sort module list - use ppos instead of m->private
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]