On venerdì 24 agosto 2007, Jeff Dike wrote: > On Thu, Aug 23, 2007 at 04:54:59PM +0200, Blaisorblade wrote: > > > actually. Personally I'd prefer: > > > > > > else > > > type = OS_TYPE_DIR; > > > > I strongly agree with this style; beyond style itself, one strong reason > > is that joining statements hinder singlestepping through function code > > (it's easy to run gdb on UML, and anyway kgdb exists). > > How does that help? gdb should stop as easily on a "else foo;" line as on > else > foo; > right? Sorry, a better example is on: if (bar) foo; where the test and foo are two distinct parts. One step is "I execute the if", another (possible) step is "I perform foo" - which is not easy to tell if it is not on a different line. -- "Doh!" (cit.), I've made another mistake! Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade
Attachment:
signature.asc
Description: This is a digitally signed message part.
- References:
- [PATCH 6/6] UML - Fix hostfs style
- From: Jeff Dike <[email protected]>
- Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- From: Blaisorblade <[email protected]>
- Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- From: Jeff Dike <[email protected]>
- [PATCH 6/6] UML - Fix hostfs style
- Prev by Date: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
- Next by Date: Re: [Tech-board-discuss] Re: [Ksummit-2007-discuss] Re: Linux Foundation Technical Advisory Board Elections
- Previous by thread: Re: [uml-devel] [PATCH 6/6] UML - Fix hostfs style
- Next by thread: [PATCH 1/2] scripts/get_maintainer.pl
- Index(es):
 |