On Fri, 24 Aug 2007, Paul Mundt wrote:
> On Fri, Aug 24, 2007 at 05:49:42AM -0400, Robert P. J. Day wrote:
> > On Fri, 24 Aug 2007, Paul Mundt wrote:
> >
> > > On Fri, Aug 24, 2007 at 05:19:29AM -0400, Robert P. J. Day wrote:
> > > >
> > > > perhaps i'm missing it, but it seems that the macro __setup_param is
> > > > entirely superfluous:
> > > >
> > > > $ grep -rw __setup_param *
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \
> > > > include/linux/init.h: __setup_param(str, unique_id, NULL, 0)
> > > > include/linux/init.h: __setup_param(str, fn, fn, 0)
> > > > include/linux/init.h: __setup_param(str, fn, fn, 1)
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */
> > > > $
> > > >
> > > > or am i must misreading something badly?
> >
> > > Superfluous how? It does different things depending on whether
> > > MODULE is defined or not. It's a good indicator of how often people
> > > use __setup_param() from module context though, given the complete
> > > mismatch of parameters. It's probably worth fixing that up at least.
> >
> > never mind, i've already clued in. up too long, and trying to do too
> > many things at once. more sleep or more coffee -- time to make a
> > decision. sorry for the noise.
> >
> That's great, but you've ignored the second part of my mail. I'll
> summarize:
>
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \
> > > > include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */
>
> Notice the problem now? :-)
oh, certainly. i'm just thinking that, in my condition, i shouldn't
be allowed to submit patches or operate heavy machinery at the moment.
:-)
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
