Jesper Juhl wrote:
> [kv]alloc() return void *. No need to cast the return value.
> @@ -5756,7 +5756,7 @@ static int osst_probe(struct device *dev)
> write_lock(&os_scsi_tapes_lock);
> if (os_scsi_tapes == NULL) {
> os_scsi_tapes =
> - (struct osst_tape **)kmalloc(osst_max_dev * sizeof(struct osst_tape *),
> + kmalloc(osst_max_dev * sizeof(struct osst_tape *),
> GFP_ATOMIC);
> if (os_scsi_tapes == NULL) {
> write_unlock(&os_scsi_tapes_lock);
Three lines later:
for (i=0; i < osst_max_dev; ++i) os_scsi_tapes[i] = NULL;
This wants to be
os_scsi_tapes = kcalloc(osst_max_dev, sizeof(struct osst_tape *), GFP_ATOMIC);
Eike
Attachment:
signature.asc
Description: This is a digitally signed message part.
- Follow-Ups:
- References:
- Prev by Date: Re: "double" hpet clocksource && hard freeze [bisected]
- Next by Date: Re: [RFC] USB: driver for iphone charging
- Previous by thread: [PATCH 19/30] scsi: Remove explicit casts of [kv]alloc return values in osst driver
- Next by thread: Re: [PATCH 19/30] scsi: Remove explicit casts of [kv]alloc return values in osst driver
- Index(es):
 |