Re: [-mm patch] enforce noreplace-smp in alternative_instructions()

Frederik Deweerdt wrote:
> On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote:
>   
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc3/2.6.23-rc3-mm1/
>>
>>     
> Hi Jeremy,
>
> arch/i386/kernel/alternative.c:alternative_instructions() doesn't
> check for noreplace-smp before setting capability bits and freeing the
> __smp_locks section.
>
> Every call to alternatives_smp_unlock() checks for noreplace-smp
> beforehand, so remove the check from there.
>
> Boot tested on i386 with UP+noreplace-smp (lguest) and SMP (real hardware)
>   

Does this fix a real problem?  Or is there just some redundancy? 
Wouldn't it be better to put the noreplace_smp test in one place?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
  - From: Frederik Deweerdt <[email protected]>

References:
- 2.6.23-rc3-mm1
  - From: Andrew Morton <[email protected]>
- [-mm patch] enforce noreplace-smp in alternative_instructions()
  - From: Frederik Deweerdt <[email protected]>

Prev by Date: Re: [linux-usb-devel] [GIT PATCH] USB fixes for 2.6.23-rc3
Next by Date: Re: [linux-usb-devel] [GIT PATCH] USB fixes for 2.6.23-rc3
Previous by thread: Re: [PATCH] Fix out-by-one error in traps.c
Next by thread: Re: [-mm patch] enforce noreplace-smp in alternative_instructions()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]