Re: x86_64-dynticks-disable-hpet_id_legsup-hpets.patch hangs the system

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 23 Aug 2007 16:54:23 +0530
Gautham R Shenoy <ego@in.ibm.com> wrote:

> 2.6.23-rc3-mm1 renders my machine unresponsive during bootup.
> I've been observing this problem in 2.6.22-rc2-mm2 as well.
> The boot log, the cpuinfo and .config have been appened at the
> end
> 
> After embedding a few debug printk's in start_kernel, I noticed that
> the last function to be executed was calibrate_delay()
> 
> Further, from the mm-bisect, the following patch turned out to be the
> culprit:
> 
> x86_64-dynticks-disable-hpet_id_legsup-hpets.patch 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@elte.hu>
> Cc: john stultz <johnstul@us.ibm.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  arch/i386/kernel/hpet.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN arch/i386/kernel/hpet.c~x86_64-dynticks-disable-hpet_id_legsup-hpets arch/i386/kernel/hpet.c
> --- a/arch/i386/kernel/hpet.c~x86_64-dynticks-disable-hpet_id_legsup-hpets
> +++ a/arch/i386/kernel/hpet.c
> @@ -336,7 +336,7 @@ int __init hpet_enable(void)
>  
>  	clocksource_register(&clocksource_hpet);
>  
> -	if (id & HPET_ID_LEGSUP) {
> +	if (0 && (id & HPET_ID_LEGSUP)) {
>  		hpet_enable_int();
>  		hpet_reserve_platform_timers(id);
>  		/*
> 
> Any particular reason for this patch [There is no changelog :-)]? 
> Without this patch the mm-kernel seems to behave just fine for me.

Oh damn.  That patch is required to prevent a boot-time div-by-zero
on my old nocona machine.

I have a new set of x86_64-dynticks patches from Thomas to look at
so I guess it's reset-and-start-again time on that front.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/