Re: [PATCH] Console events and accessibility

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Hi,

Greg KH, le Thu 23 Aug 2007 09:33:18 -0700, a écrit :
> Yes I did, sorry.  Do you have a pointer for it, all I see is these
> patches in -mm:
> 	console-keyboard-events-and-accessibility.patch

Here is the patch

> 	console-keyboard-events-and-accessibility-fix.patch
> 	console-keyboard-events-and-accessibility-fix-2.patch

These are just EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL and #include fixes.

> > > The patches look sane but you should change the global symbols to play
> > > nicer in the namespace.  Care to respin them together with this change?
> > 
> > You mean inverse_translate and screen_glyph?
> 
> Yes.  Also, things like "register_keyboard_notifier" should be
> "keyboard_register_notifer", trying to keep everything in the
> "keyboard*" namespace to make things a bit easier overall[1].

Ok.

> > Well, the biggest problem is that we'd like to output on serial _before_
> > /dev gets mounted.
> 
> As we can do this today with the console layer (think boot consoles over
> serial and network and even USB), it should not be that tough.  Just be
> an early console yourself also.

Yes, that's on the plan too, but in some cases (like braille devices),
the driver needs to read from the port too, which is not provided by
early consoles.

> > > It doesn't look like these changes handle scrolling of the console, do
> > > they?
> > 
> > Ah, indeed, speakup doesn't seem to handle it, that's why I forgot it in
> > the patch.  I'll see what needs to be done.
> 
> Does speakup need to handle it?

I don't know exactly, but most probably yes, because else the cursor
position gets wrong.

> Also, we really would like to see the users of these hooks (meaning the
> speakup drivers) go into the tree at the same time the hooks do, as we
> don't like hooks with no users in the kernel.

OK.  Having my patches in the -mm tree for just some review time is
fine: at least we know that the way they're done is ok for people (or
else we're told how to fix them).

> I know the speakup code needs a lot of work to bring it up to
> kernel-acceptance level.  Has this work been done, or is it happening?

It is happening.

> If you need help in this area, I can see about doing a bit as I did a
> lot of cleanup of this codebase a few years ago.  I also know of a few
> users who are willing to help test this stuff out.

Oh, great!  Maybe Kirk should be contacted so he gives access to the git
tree of speakup.

Samuel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/