Re: [PATCH] make kobject dynamic allocation check use kallsyms_lookup()

[Greg KH <greg@kroah.com>]

On Thu, Aug 23, 2007 at 10:48:23AM +0530, Satyam Sharma wrote:
> Hi Dave,
> 
> 
> On Wed, 22 Aug 2007, Dave Hansen wrote:
> > 
> > One of the top ten sysfs problems is that users use statically
> > allocated kobjects.  This patch reminds them that this is a
> > naughty thing.
> 
> Hmm, I might've missed previous discussion regarding this, but I'm
> curious to know why using statically allocated kobjects is "naughty".
> The code / warnings / printk messages below indicate this is only a
> "silly/janitorial" issue?
> 
> The reason I ask is that if it is serious, there is no reason why this
> check cannot be done at build-time itself, instead of this runtime
> kludge in the kernel -- catching potential bugs at build-time is always
> desirable. Modpost or some such tool can be taught to detect kobjects
> allocated statically in vmlinux/modules -- or there can be other build-
> time solutions, possibly. Have you considered such an approach?

If you have a patch to do so, I would appreciate it.

But the main reason I don't push such a change into Linus's tree is that
there are still a lot of statically allocated kobjects today, like all
driver definitions :(

Converting them to be dynamic is on my list of things to do, it's just a
ways down there.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/