Re: [PATCH] Send exit code through for taskstats.ac_exitcode

Jonathan Lim wrote:
> taskstats.ac_exitcode is assigned to task_struct.exit_code in bacct_add_tsk()
> through the following kernel function calls: 
> 
>   do_exit()
>     taskstats_exit_send()
>       fill_pid()
>         bacct_add_tsk()
> 
> The problem is that in do_exit(), task_struct.exit_code is set to 'code' 
> only after taskstats_exit_send() has been called.  So we need to send 'code'
> through to bacct_add_tsk().
> 

Hi, Jonathan,

The patches look like a step in the right direction, I would suggest an alternate
implementation

Why can't we assign tsk->exit_code to code earlier? Can we not move up the assignment
to before taskstats_exit()? Wouldn't that be much simpler?

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: [PATCH] Send exit code through for taskstats.ac_exitcode
  - From: Jonathan Lim <[email protected]>

References:
- [PATCH] Send exit code through for taskstats.ac_exitcode
  - From: Jonathan Lim <[email protected]>

Prev by Date: How Linux /proc filesystem convert a fd to the actual pathname?
Next by Date: Re: [PATCH 0/3] x86_64 EFI runtime service support
Previous by thread: [PATCH] Send exit code through for taskstats.ac_exitcode
Next by thread: Re: [PATCH] Send exit code through for taskstats.ac_exitcode
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]