Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree

On 08/18, Neil Horman wrote:
>
> +static int proc_pid_limits(struct task_struct *task, char *buffer)
> +{
> +	unsigned int i;
> +	int count = 0;
> +	unsigned long flags;
> +	char *bufptr = buffer;
> +
> +	struct rlimit rlim[RLIM_NLIMITS];
> +
> +	read_lock(&tasklist_lock);
> +	lock_task_sighand(task, &flags);
> +	if (task->signal == NULL){
> +		unlock_task_sighand(task, &flags);
> +		read_unlock(&tasklist_lock);

Neil, please, don't add tasklist_lock again. It was not easy to wipe it from
fs/proc/ :) Just change this code to use rcu_read_lock().

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
    • From: Neil Horman <[email protected]>

• References:
  • Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
    • From: Oleg Nesterov <[email protected]>
  • Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
    • From: Neil Horman <[email protected]>
  • Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
    • From: Oleg Nesterov <[email protected]>
  • Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
    • From: Neil Horman <[email protected]>

• Prev by Date: Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
• Next by Date: Re: [PATCH] [1/4] x86_64: Fail dma_alloc_coherent on dma less devices
• Previous by thread: Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
• Next by thread: Re: + proc-export-a-processes-resource-limits-via-proc-pid.patch added to -mm tree
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]