Re: [PATCH 002 of 6] Introduce rq_for_each_segment replacing rq_for_each_bio

[Jan Engelhardt <jengelh@computergmbh.de>]

On Aug 18 2007 20:07, Satyam Sharma wrote:
>On Fri, 17 Aug 2007, Geert Uytterhoeven wrote:
>
>> On Thu, 16 Aug 2007, NeilBrown wrote:
>> [...]
>> >  		dev_dbg(&dev->sbd.core,
>> >  			"%s:%u: bio %u: %u segs %u sectors from %lu\n",
>> > -			__func__, __LINE__, i, bio_segments(bio),
>> > -			bio_sectors(bio), sector);
>> > -		bio_for_each_segment(bvec, bio, j) {
>> > +			__func__, __LINE__, i, bio_segments(iter.bio),
>> > +			bio_sectors(iter.bio),
>> > +			(unsigned long)iter.bio->bi_sector);
>>                         ^^^^^^^^^^^^^^^
>> Superfluous cast: PS3 is 64-bit only, and casts are evil.

bi_sector is sector_t. The cast is ok, because printf will warn, and rightfully
so since sector_t may just change its shape underneath. It would not be so much
of a problem if printf() was not a varargs function, but it is, and hence,
passing an object bigger than the format specifier can make problems.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/