Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

On Friday 17 August 2007 05:42, Linus Torvalds wrote:
> On Fri, 17 Aug 2007, Paul Mackerras wrote:
> > I'm really surprised it's as much as a few K.  I tried it on powerpc
> > and it only saved 40 bytes (10 instructions) for a G5 config.
>
> One of the things that "volatile" generally screws up is a simple
>
> 	volatile int i;
>
> 	i++;

But for atomic_t people use atomic_inc() anyways which does this correctly.
It shouldn't really matter for atomic_t.

I'm worrying a bit that the volatile atomic_t change caused subtle code 
breakage like these delay read loops people here pointed out.
Wouldn't it be safer to just re-add the volatile to atomic_read() 
for 2.6.23? Or alternatively make it asm(), but volatile seems more
proven.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Satyam Sharma <[email protected]>

• References:
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Paul Mackerras <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Linus Torvalds <[email protected]>

• Prev by Date: [-mm PATCH 6/9] Memory controller add per container LRU and reclaim (v6)
• Next by Date: [-mm PATCH 3/9] Memory controller accounting setup (v6)
• Previous by thread: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Next by thread: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]