Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

Herbert Xu writes:

> Can you find an actual atomic_read code snippet there that is
> broken without the volatile modifier?

There are some in arch-specific code, for example line 1073 of
arch/mips/kernel/smtc.c.  On mips, cpu_relax() is just barrier(), so
the empty loop body is ok provided that atomic_read actually does the
load each time around the loop.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>

• References:
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Paul Mackerras <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Paul Mackerras <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Satyam Sharma <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Paul Mackerras <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Paul Mackerras <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
    • From: Herbert Xu <[email protected]>

• Prev by Date: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Next by Date: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Previous by thread: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Next by thread: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]