On 8/16/07, Jeff Garzik <[email protected]> wrote:
> Sonic Zhang wrote:
> > +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev)
> > +{
> > + int mode = adev->pio_mode - XFER_PIO_0;
> > + unsigned long base = (unsigned long)ap->ioaddr.ctl_addr;
>
>
> (added Bryan Wu to CC)
>
> Someone needs to need fix the bfin architecture: the addresses on the
> bfin_read/bfin_write functions should be 'void __iomem *' not unsigned long.
there are no address pointers anymore, so there is nothing to cast ...
the bfin_read/bfin_write macros are done in sexy asm:
#define bfin_write8(addr,val) __asm__ __volatile__("b[%0] = %1;" ::
"a"(addr), "d"(val))
or i'm misunderstanding what you mean ...
where do you see (unsigned long) ?
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
