Re: [PATCH] Fix a memory leak in em28xx_usb_probe()

Hi Jesper,

On 8/9/07, Jesper Juhl <[email protected]> wrote:
> EHLO,
>
> If, in em28xx_usb_probe() the memory allocation
> 	dev->alt_max_pkt_size = kmalloc(32*
> 						dev->num_alt,GFP_KERNEL);
> fails, then we'll bail out and return -ENOMEM.
> The problem is that in that case we don't free the storage allocated
> to 'dev', thus causing a memory leak.
>
> This patch fixes the leak by freeing 'dev' before we return -ENOMEM.
> This fixes Coverity bug #647.
>
>
> Signed-off-by: Jesper Juhl <[email protected]>

Acked-by: Markus Rechberger <[email protected]>

thanks,
Markus

> ---
>
>  drivers/media/video/em28xx/em28xx-video.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/em28xx/em28xx-video.c
> b/drivers/media/video/em28xx/em28xx-video.c
> index 2c7b158..40307f3 100644
> --- a/drivers/media/video/em28xx/em28xx-video.c
> +++ b/drivers/media/video/em28xx/em28xx-video.c
> @@ -1772,6 +1772,7 @@ static int em28xx_usb_probe(struct usb_interface
> *interface,
>  	if (dev->alt_max_pkt_size == NULL) {
>  		em28xx_errdev("out of memory!\n");
>  		em28xx_devused&=~(1<<nr);
> +		kfree(dev);
>  		return -ENOMEM;
>  	}
>
>
>
>
>


-- 
Markus Rechberger
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Fix a memory leak in em28xx_usb_probe()
    • From: Jesper Juhl <[email protected]>

• Prev by Date: Re: [PATCH 6/24] make atomic_read() behave consistently on frv
• Next by Date: Re: [PATCH 4 of 5 ] /drivers/char/rio ioremap balancing/ returncode check
• Previous by thread: [PATCH] Fix a memory leak in em28xx_usb_probe()
• Next by thread: [PATCH 0/4] Use one zonelist per node instead of multiple zonelists v3
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]