Re: [PATCH 21/25][V3] export cpu_gdt_descr

On 8/15/07, Andi Kleen <[email protected]> wrote:
> > +#ifdef CONFIG_PARAVIRT
> > +extern unsigned long *cpu_gdt_descr;
>
> No externs in .c files
>
> Normally they should be where the variable is defined
> anyways.
Given that this  variable is defined in head.S, what do you propose?
AFAICT, this is the very duty of this file (x8664_syms.c), and the
extern is also used in other symbols like the memcpy family

-- 
Glauber de Oliveira Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 21/25][V3] export cpu_gdt_descr
    • From: Andi Kleen <[email protected]>

• References:
  • [PATCH 12/25][V3] turn msr.h functions into native versions
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 14/25][V3] get rid of inline asm for load_cr3
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 15/25][V3] introducing paravirt_activate_mm
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 16/25][V3] turn page operations into native versions
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 17/25][V3] introduce paravirt_release_pgd()
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 18/25][V3] turn priviled operations into macros in entry.S
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 20/25][V3] replace syscall_init
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 21/25][V3] export cpu_gdt_descr
    • From: Glauber de Oliveira Costa <[email protected]>
  • Re: [PATCH 21/25][V3] export cpu_gdt_descr
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures
• Next by Date: Re: Regression in 2.6.23-rc2-mm2, mounting cpusets causes a hang
• Previous by thread: Re: [PATCH 21/25][V3] export cpu_gdt_descr
• Next by thread: Re: [PATCH 21/25][V3] export cpu_gdt_descr
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]