Re: [PATCH] fix panic in jbd by adding locks

  Hello,

> It is possible to panic the box by a race condition that exists in the
> journalling code where we do not take the j_revoke_lock when traversing the
> journal's revoked record list.  This patch has been tested and we haven't seen
> the issue yet, its a rather straightforward and correct (at least I think so :)
> fix.  Thank you,
  In principle, the patch looks fine. The only thing I'm wondering about
is how that panic can happen... Journal write_revoke_records() is called
from journal_commit_transaction() when revoke table for the committing
transaction shouldn't see any further changes. So maybe the patch is
masking a different problem.
  Do you have a way of reproducing the problem? Any stack trace
available?

								Honza
-- 
Jan Kara <[email protected]>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix panic in jbd by adding locks
    • From: Josef Bacik <[email protected]>

• References:
  • [PATCH] fix panic in jbd by adding locks
    • From: Josef Bacik <[email protected]>

• Prev by Date: Re: [PATCH] Documentation: fix getdelays.c example -l option and segv
• Next by Date: Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer
• Previous by thread: [PATCH] fix panic in jbd by adding locks
• Next by thread: Re: [PATCH] fix panic in jbd by adding locks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]