Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)

> YAMAMOTO Takashi wrote:
> >> +	lock_meta_page(page);
> >> +	/*
> >> +	 * Check if somebody else beat us to allocating the meta_page
> >> +	 */
> >> +	race_mp = page_get_meta_page(page);
> >> +	if (race_mp) {
> >> +		kfree(mp);
> >> +		mp = race_mp;
> >> +		atomic_inc(&mp->ref_cnt);
> >> +		res_counter_uncharge(&mem->res, 1);
> >> +		goto done;
> >> +	}
> > 
> > i think you need css_put here.
> 
> Thats correct. We do need css_put in this path.
> 
> Thanks,
> Vaidy

v5 still seems to have the problem.

YAMAMOTO Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
    • From: Balbir Singh <[email protected]>

• References:
  • Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
    • From: Vaidyanathan Srinivasan <[email protected]>

• Prev by Date: Linux 2.4.35.1
• Next by Date: Re: [patch 2/2] Sort module list by pointer address to get coherent sleepable seq_file iterators
• Previous by thread: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
• Next by thread: Re: [-mm PATCH 4/9] Memory controller memory accounting (v4)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]