* Andi Kleen | 2007-08-15 02:20:35 [+0200]:
>> My config with march=pentium-m and gcc (GCC) 4.1.2 (Gentoo 4.1.2):
>> text data bss dec hex filename
>> 3434150 249176 176128 3859454 3ae3fe atomic_normal/vmlinux
>> 3435308 249176 176128 3860612 3ae884 atomic_inlineasm/vmlinux
>
>What is the difference between atomic_normal and atomic_inlineasm?
atomic normal is Linus' tree, commit 28e8351. Inline asm is with this
patch. I wrote this in 0/2 (you want this here as well?).
>
>> /**
>> * atomic_read - read atomic variable
>> * @v: pointer of type atomic_t
>> - *
>> + *
>
>Please don't change white space in patches
I fixed white space errors. SubmitChecklist:24 says I should not
introduce any new ones so fixing existig sounds like the right thing to
do.
No white space fixing in future?
>
>> * Atomically reads the value of @v.
>> - */
>> -#define atomic_read(v) ((v)->counter)
>> + */
>> +static __inline__ int atomic_read(const atomic_t *v)
>> +{
>> + int t;
>> +
>> + __asm__ __volatile__(
>
>And don't use __*__ in new code
Okey.
>
>-Andi
Sebastian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
