Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c

On Wed, 15 Aug 2007, Andi Kleen wrote:

> > > The interrupt handler shouldn't touch zone_flag. If it wants
> > > to it would need to be converted to a local_t and incremented/decremented
> > > (should be about the same cost at least on architectures with sane
> > > local_t implementation) 
> > 
> > That would mean we need to fork the code for reclaim?
> 
> Not with the local_t increment.

Ok I have a vague idea on how this could but its likely that the 
changes make things worse rather than better. Additional reference to a 
new cacheline (per cpu but still), preempt disable. Lots of code at all
call sites. Interrupt enable/disable is quite efficient in recent 
processors.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>

• References:
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
• Next by Date: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
• Previous by thread: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
• Next by thread: Re: [RFC 4/9] Atomic reclaim: Save irq flags in vmscan.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]