Re: [2.6 patch] cpqphp_ctrl.c: remove dead code

[Kristen Carlson Accardi <kristen.c.accardi@intel.com>]

On Fri, 10 Aug 2007 01:39:10 +0200
Adrian Bunk <bunk@kernel.org> wrote:

> As I've wrote in the patch description, all it does is to remove an if() 
> check that could never be false (which is easily verifyable if you look 
> at the source code).
> 
> I've also verified that my patch does not change a single bit in the 
> object file (after compilation with gcc 4.2.1).

while you are correct that your patch will not change the object,
the reason I think that we should not do this patch is because it appears
to me that this code path was meant to be taken, and perhaps it was a 
mistake to return -ENOMEM further up (the reason the code isn't taken).
It seems to me that the thing to do is to leave the code as is, and then when
someone picks up the code again, they can clean it up after they've determined
they truly don't want that code path taken.

My definition of trivial is a patch that is both simple and obviously the 
right thing to do.
Kristen
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/