Re: 2.6.23-rc2-mm2: strtol_check_range patches

[Satyam Sharma <satyam@infradead.org>]

On Mon, 13 Aug 2007, Alexey Dobriyan wrote:

> Andrew please drop
> 	introduce-strtol_check_range-fix.patch
> 	introduce-strtol_check_range.patch
> from -mm.
> 
> strtol_check_range() semantics is broken, because caller can't distinguish
> -E from valid negative number if he wants to negative integers.

As you wrote, the comment does mention that you can't use this to convert
negative integers, and it WARN()'s if the user tries that anyway.

> Comment
> mentions this, but we don't want to such horrible and not well thought
> out function to lib/ .
> 
> If anything it should be strtonum() with additional trailing '\n' check.

That's fine, I'll use strtonum() in any case. It turns out the behaviour
that we want is precisely what strtonum() offers, plus that also works for
negative integers, so we might as well just copy it over.

Andrew, I'll diff a new patch implementing strtonum(3) _not_ based on this
one, so you may safely drop this.


Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/