Linus Torvalds wrote:
On Fri, 10 Aug 2007, Luck, Tony wrote:Here are the functions in which they occur in the object file. You may have to chase down some inlining to find the function that actually uses atomic_*().Could you just make the "atomic_read()" and "atomic_set()" functions be inline functions instead?That way you get nice compiler warnings when you pass the wrong kind of object around. Sostatic void atomic_set(atomic_t *p, int value) { *(volatile int *)&p->value = value; } static int atomic_read(atomic_t *p) { return *(volatile int *)&p->value; } etc...
I'll do this for the whole patchset. Stay tuned for the resubmit. -- Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Paul Mackerras <[email protected]>
- Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- References:
- [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Chris Snook <[email protected]>
- RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: "Luck, Tony" <[email protected]>
- Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Chris Snook <[email protected]>
- RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: "Luck, Tony" <[email protected]>
- Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Andreas Schwab <[email protected]>
- RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: "Luck, Tony" <[email protected]>
- Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Chris Snook <[email protected]>
- RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: "Luck, Tony" <[email protected]>
- RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- From: Linus Torvalds <[email protected]>
- [PATCH 9/24] make atomic_read() behave consistently on ia64
- Prev by Date: RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- Next by Date: Re: [v4l-dvb-maintainer] [2.6 patch] dvb_frontend_ioctl(): fix check-after-use
- Previous by thread: RE: [PATCH 9/24] make atomic_read() behave consistently on ia64
- Next by thread: Re: [PATCH 9/24] make atomic_read() behave consistently on ia64
- Index(es):