Re: [patch 05/11] dm-snap: remove SECTOR_SHIFT define

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 10, 2007 at 10:02:09PM +0200, Jan Blunck wrote:
> Sector size on Linux is always 512 bytes. Don't even try to give the
> impression this is changeable.

If that's what worries you, add a comment next to the definition,
perhaps?

It's there so you can easily locate all the places within dm that
perform these conversions by using a simple search.  Searching for '9'
wouldn't be as easy.  (I don't know about other people, but I find the
code easier to read the way it is.)

BTW When changing one thing across the whole of dm, you may combine
the sub-component patches into a single patch.

Alasdair
-- 
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux