Re: [PATCH] flush icache before set_pte() on ia64 take9 [2/2] flush icache at set_pte

["David Mosberger-Tang" <dmosberger@gmail.com>]

On 8/10/07, Luck, Tony <tony.luck@intel.com> wrote:

> +       if (pte_exec(pteval) &&    // flush only new executable page.
> +           pte_present(pteval) && // swap out ?
> +           pte_user(pteval) &&    // ignore kernel page
> +           (!pte_present(*ptep) ||// do_no_page or swap in, migration,
> +               pte_pfn(*ptep) != pte_pfn(pteval))) // do_wp_page(), page copy
> +               /* load_module() calles flush_icache_range() explicitly*/
> +               __ia64_sync_icache_dcache(pteval);
>

> So now the only remaining task is to convince myself that this
> new version covers all the cases.

What about code-size?

Also, is it OK to call a function from all places where a set_pte() is
being done?  I'd hope so, but it's a really low-level operation...

  --david
-- 
Mosberger Consulting LLC, http://www.mosberger-consulting.com/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/