Re: [PATCH] [8/12] x86_64: Use global flag to disable broken local apic timer on AMD CPUs.

[Cal Peake <cp@absolutedigital.net>]

On Thu, 9 Aug 2007, Andi Kleen wrote:

> Index: linux/arch/i386/kernel/apic.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/apic.c
> +++ linux/arch/i386/kernel/apic.c
> @@ -61,8 +61,9 @@ static int enable_local_apic __initdata 
>  
>  /* Local APIC timer verification ok */
>  static int local_apic_timer_verify_ok;
> -/* Disable local APIC timer from the kernel commandline or via dmi quirk */
> -static int local_apic_timer_disabled;
> +/* Disable local APIC timer from the kernel commandline or via dmi quirk
> +   or using CPU MSR check */
> +int local_apic_timer_disabled;
>  /* Local APIC timer works in C2 */
>  int local_apic_timer_c2_ok;
>  EXPORT_SYMBOL_GPL(local_apic_timer_c2_ok);
> @@ -370,9 +371,6 @@ void __init setup_boot_APIC_clock(void)
>  	long delta, deltapm;
>  	int pm_referenced = 0;
>  
> -	if (boot_cpu_has(X86_FEATURE_LAPIC_TIMER_BROKEN))
> -		local_apic_timer_disabled = 1;
> -
>  	/*
>  	 * The local apic timer can be disabled via the kernel
>  	 * commandline or from the test above. Register the lapic

Andi, just noticed that the comment above needs to be updated now.

-- 
Cal Peake

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/