Re: [PATCH 4/7] Moved the io struct up to the generic lg.h

Stephen Rothwell wrote:

On Wed, 08 Aug 2007 20:32:15 -0400 Steven Rostedt <[email protected]>
wrote:

diff --git a/drivers/lguest/i386/lg.h b/drivers/lguest/i386/lg.h
index 64f0abe..c5ea14c 100644
--- a/drivers/lguest/i386/lg.h
+++ b/drivers/lguest/i386/lg.h
@@ -20,6 +20,8 @@
 #include <linux/err.h>
 #include <asm/semaphore.h>
 #include "irq_vectors.h"
+/* some files include this, some include the parent */
+#include "../lg.h"

Surely everything should just include the parent which allows for easier
consolidation over time. (as you are doing here)

Whats wrong with introducing an include/asm-<arch>/lg.h and have the
parent do #include <asm/lg.h> ? Seems much cleaner to me.

Cheers,
Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/7] Moved the io struct up to the generic lg.h
    • From: Steven Rostedt <[email protected]>

• References:
  • [PATCH 0/7] Modify lguest32 to make room for lguest64
    • From: Steven Rostedt <[email protected]>
  • [PATCH 4/7] Moved the io struct up to the generic lg.h
    • From: Steven Rostedt <[email protected]>
  • Re: [PATCH 4/7] Moved the io struct up to the generic lg.h
    • From: Stephen Rothwell <[email protected]>

• Prev by Date: [PATCH] at91 pm: Compilation fix for at91sam926x
• Next by Date: Re: [PATCH 2/3] UIO: Documentation
• Previous by thread: Re: [PATCH 4/7] Moved the io struct up to the generic lg.h
• Next by thread: Re: [PATCH 4/7] Moved the io struct up to the generic lg.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]