Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory

Hi Steven,

I am just being pedantic here (and I should have beaten up on Rusty
before now ...  :-)

On Thu, 09 Aug 2007 00:36:30 -0400 Steven Rostedt <[email protected]>
wrote:
>
> --- a/include/asm-i386/lg.h
> +++ b/include/asm-i386/lg.h
> @@ -1,5 +1,5 @@
> -#ifndef _LGUEST_H
> -#define _LGUEST_H
> +#ifndef _I386_LGUEST_H
> +#define _I386_LGUEST_H

Maybe _ASM_LG_H or _I386_LG_H ? And there is a comment on the #endif at
the end of the file that should match.

> +++ b/include/linux/lg.h
> @@ -0,0 +1,30 @@
> +#ifndef _LINUX_LGUEST_H
> +#define _LINUX_LGUEST_H

Maybe _LINUX_LG_H ?

Also (this is for Rusty) include/linux/lguest.h is protected by
_ASM_LGUEST_H ...

-- 
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/

Attachment: pgpLV1aMMqLhe.pgp
Description: PGP signature

---

• Follow-Ups:
  • Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
    • From: Steven Rostedt <[email protected]>

• References:
  • [PATCH 0/5 -v2] Modify lguest32 to make room for lguest64 (version 2)
    • From: Steven Rostedt <[email protected]>
  • [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
    • From: Steven Rostedt <[email protected]>

• Prev by Date: Re: early boot lockup with 2.6.23-rc1
• Next by Date: Question on IS_ERR
• Previous by thread: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
• Next by thread: Re: [PATCH 4/5 -v2] Added generic lg.h in the include/linux directory
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]