Re: [RFC 04/10] Temporary struct vfs_lookup in file_permission

On Wed, Aug 08, 2007 at 07:16:26PM +0200, Andreas Gruenbacher wrote:
> Create a temporary struct vfs_lookup in file_permission() instead of
> passing a NULL value.

NACK.  file_permission is special in that it doesn't happen in the
context of any kind of lookup operation, and the nd/intent paramater
to ->permission should be NULL in that case instead of faking up some crap.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC 04/10] Temporary struct vfs_lookup in file_permission
    • From: Andreas Gruenbacher <[email protected]>

• References:
  • [RFC 00/10] Split up struct nameidata (take 3)
    • From: Andreas Gruenbacher <[email protected]>
  • [RFC 04/10] Temporary struct vfs_lookup in file_permission
    • From: Andreas Gruenbacher <[email protected]>

• Prev by Date: Re: [patch 1/4] libata: check for AN support
• Next by Date: Re: [RFC 05/10] Use vfs_permission instead of file_permission in sys_fchdir
• Previous by thread: Re: [RFC 04/10] Temporary struct vfs_lookup in file_permission
• Next by thread: Re: [RFC 04/10] Temporary struct vfs_lookup in file_permission
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]