Eric W. Biederman wrote: >> right? I don't think we need to duplicate the code here. Or is it >> needed for later multi-sb thing? > > Right. We can do that as well. In practice in working code > there is no real difference. > > There is a little extra uniformity in rolling it ourselves, but > not enough to worry about either way. > > In the review/debug etc cycle it just wound up being a lot easier > to roll the code myself. > > By the time we get to lookup_one_len_kern it is almost impenetrable > code in namei.c where sysfs_add_dentry tends is easier to comprehend, > and to modify for debugging. Yeap, agreed. I agreed with this one too in the comment for the next patch. I guess I should have wrote here too. Sorry about the trouble. Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- [PATCH 05/25] sysfs: In sysfs_lookup don't open code sysfs_find_dirent
- From: [email protected] (Eric W. Biederman)
- [PATCH 06/25] sysfs: Simplify readdir.
- From: [email protected] (Eric W. Biederman)
- [PATCH 07/25] sysfs: Rewrite sysfs_drop_dentry.
- From: [email protected] (Eric W. Biederman)
- [PATCH 08/25] sysfs: Implement __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 09/25] sysfs: Move sysfs_get_dentry below __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 10/25] sysfs: Rewrite sysfs_get_dentry in terms of __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 11/25] sysfs: Remove s_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 12/25] sysfs: Introduce sysfs_rename_mutex
- From: [email protected] (Eric W. Biederman)
- [PATCH 13/25] sysfs: Simply sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 14/25] sysfs: Don't use lookup_one_len_kern
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 14/25] sysfs: Don't use lookup_one_len_kern
- From: Tejun Heo <[email protected]>
- Re: [PATCH 14/25] sysfs: Don't use lookup_one_len_kern
- From: [email protected] (Eric W. Biederman)
- [PATCH 05/25] sysfs: In sysfs_lookup don't open code sysfs_find_dirent
- Prev by Date: Re: Disk spin down issue on shut down/suspend to disk
- Next by Date: Re: Data corruption
- Previous by thread: Re: [PATCH 14/25] sysfs: Don't use lookup_one_len_kern
- Next by thread: Re: [PATCH 13/25] sysfs: Simply sysfs_get_dentry
- Index(es):
 |