Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S

On Wednesday 08 August 2007 15:58:06 Glauber de Oliveira Costa wrote:

> On 8/8/07, Andi Kleen <[email protected]> wrote:
> >
> > > +#define SYSRETQ                                              \
> > > +                     movq    %gs:pda_oldrsp,%rsp;    \
> > > +                     swapgs;                         \
> > > +                     sysretq;
> >
> > When the macro does more than sysret it should have a different
> > name
> That's fair. Again, suggestions are welcome. Maybe SYSCALL_RETURN ?

Sounds reasonable.

> > >  retint_restore_args:
> > > -     cli
> > > +     DISABLE_INTERRUPTS(CLBR_ANY)
> >
> > Similar.
> I don't think so. They are live here, but restore_args follows, so we
> can safely clobber anything here. Right?

The non argument registers cannot be clobbered.



-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
    • From: "Glauber de Oliveira Costa" <[email protected]>

• References:
  • Introducing paravirt_ops for x86_64
    • From: Glauber de Oliveira Costa <[email protected]>
  • Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
    • From: Andi Kleen <[email protected]>
  • Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
    • From: "Glauber de Oliveira Costa" <[email protected]>

• Prev by Date: Re: [PATCH 3/25] [PATCH] irq_flags / halt routines
• Next by Date: Re: Error message from device_rename in drivers/base/core.c
• Previous by thread: Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
• Next by thread: Re: [PATCH 18/25] [PATCH] turn priviled operations into macros in entry.S
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]