Teach sysfs_update_file how to handle multiple sysfs superblocks. Again we are just iterating over the superblocks to so all of the filesystem modification notifications work as expected. Signed-off-by: Eric W. Biederman <[email protected]> --- fs/sysfs/file.c | 35 +++++++++++++++++++++-------------- 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index cff054f..1e6f9df 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -462,7 +462,8 @@ EXPORT_SYMBOL_GPL(sysfs_add_file_to_group); int sysfs_update_file(struct kobject * kobj, const struct attribute * attr) { struct sysfs_dirent *victim_sd = NULL; - struct dentry *victim = NULL; + struct super_block *sb; + struct dentry *victim; int rc; rc = -ENOENT; @@ -471,21 +472,27 @@ int sysfs_update_file(struct kobject * kobj, const struct attribute * attr) goto out; mutex_lock(&sysfs_rename_mutex); - victim = sysfs_get_dentry(sysfs_sb, victim_sd); - mutex_unlock(&sysfs_rename_mutex); - if (IS_ERR(victim)) { - rc = PTR_ERR(victim); - victim = NULL; - goto out; + sysfs_grab_supers(); + list_for_each_entry(sb, &sysfs_fs_type.fs_supers, s_instances) { + victim = sysfs_get_dentry(sb, victim_sd); + if (!victim) + continue; + if (IS_ERR(victim)) { + rc = PTR_ERR(victim); + victim = NULL; + goto out_unlock; + } + mutex_lock(&victim->d_inode->i_mutex); + victim->d_inode->i_mtime = CURRENT_TIME; + fsnotify_modify(victim); + mutex_unlock(&victim->d_inode->i_mutex); + rc = 0; + dput(victim); } - - mutex_lock(&victim->d_inode->i_mutex); - victim->d_inode->i_mtime = CURRENT_TIME; - fsnotify_modify(victim); - mutex_unlock(&victim->d_inode->i_mutex); - rc = 0; + out_unlock: + sysfs_release_supers(); + mutex_unlock(&sysfs_rename_mutex); out: - dput(victim); sysfs_put(victim_sd); return rc; } -- 1.5.1.1.181.g2de0 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 22/25] sysfs: sysfs_uptdate_file handle multiple superblocks
- From: Tejun Heo <[email protected]>
- [PATCH 23/25] sysfs: Implement sysfs tagged directory support.
- From: [email protected] (Eric W. Biederman)
- Re: [PATCH 22/25] sysfs: sysfs_uptdate_file handle multiple superblocks
- References:
- [PATCH 5/5] sysfs: make sysfs_addrm_finish() return void
- From: Tejun Heo <[email protected]>
- [PATCH 02/25] sysfs: Remove sysfs_instantiate
- From: [email protected] (Eric W. Biederman)
- [PATCH 03/25] sysfs: Use kill_anon_super
- From: [email protected] (Eric W. Biederman)
- [PATCH 04/25] sysfs: Make sysfs_mount static
- From: [email protected] (Eric W. Biederman)
- [PATCH 05/25] sysfs: In sysfs_lookup don't open code sysfs_find_dirent
- From: [email protected] (Eric W. Biederman)
- [PATCH 06/25] sysfs: Simplify readdir.
- From: [email protected] (Eric W. Biederman)
- [PATCH 07/25] sysfs: Rewrite sysfs_drop_dentry.
- From: [email protected] (Eric W. Biederman)
- [PATCH 08/25] sysfs: Implement __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 09/25] sysfs: Move sysfs_get_dentry below __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 10/25] sysfs: Rewrite sysfs_get_dentry in terms of __sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 11/25] sysfs: Remove s_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 12/25] sysfs: Introduce sysfs_rename_mutex
- From: [email protected] (Eric W. Biederman)
- [PATCH 13/25] sysfs: Simply sysfs_get_dentry
- From: [email protected] (Eric W. Biederman)
- [PATCH 14/25] sysfs: Don't use lookup_one_len_kern
- From: [email protected] (Eric W. Biederman)
- [PATCH 15/25] vfs: Remove lookup_one_len_kern
- From: [email protected] (Eric W. Biederman)
- [PATCH 16/25] sysfs: Support for preventing unmounts.
- From: [email protected] (Eric W. Biederman)
- [PATCH 17/25] sysfs: Rewrite rename in terms of sysfs dirents
- From: [email protected] (Eric W. Biederman)
- [PATCH 18/25] sysfs: Rewrite sysfs_move_dir in terms of sysfs dirents
- From: [email protected] (Eric W. Biederman)
- [PATCH 19/25] sysfs: sysfs_get_dentry add a sb parameter
- From: [email protected] (Eric W. Biederman)
- [PATCH 20/25] sysfs: Rename Support multiple superblocks
- From: [email protected] (Eric W. Biederman)
- [PATCH 21/25] sysfs: sysfs_chmod_file handle multiple superblocks
- From: [email protected] (Eric W. Biederman)
- [PATCH 5/5] sysfs: make sysfs_addrm_finish() return void
- Prev by Date: Re: allow non root users to set io priority "idle" ?
- Next by Date: [PATCH 23/25] sysfs: Implement sysfs tagged directory support.
- Previous by thread: [PATCH 21/25] sysfs: sysfs_chmod_file handle multiple superblocks
- Next by thread: [PATCH 23/25] sysfs: Implement sysfs tagged directory support.
- Index(es):