Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)

Quoting James Morris ([email protected]):
> On Tue, 7 Aug 2007, Serge E. Hallyn wrote:
> 
> > Shall I resend without the LSM_NEED_LOCK, or do you still want a more
> > fundamental change?
> 
> 
> Removing the needlock is enough, the rest was just a query/suggestion.

Ok - I'll explictly lock the i_mutex in
fs/splice.c:generic_file_splice_write().  The ugliness there is that
the mutex will always be taken - even if there is no xattr to be
removed or even if CONFIG_SECURITY=n.

I guess I'll do some perf runs and see what kind of impact that has.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
    • From: "Serge E. Hallyn" <[email protected]>
  • Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
    • From: James Morris <[email protected]>
  • Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
    • From: "Serge E. Hallyn" <[email protected]>
  • Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
    • From: James Morris <[email protected]>

• Prev by Date: Re: Old -rt patches
• Next by Date: Re: [GIT PATCH] scsi bug fixes for 2.6.23-rc2
• Previous by thread: Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
• Next by thread: Re: [PATCH 1/1] file capabilities: clear fcaps on inode change (v2)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]