Re: [PATCH 2/2] wait for page writeback when directly reclaiming contiguous areas

On Thu, 02 Aug 2007 19:18:43 +0100 Andy Whitcroft <[email protected]> wrote:

> @@ -458,8 +475,15 @@ static unsigned long shrink_page_list(struct list_head *page_list,
>  		if (page_mapped(page) || PageSwapCache(page))
>  			sc->nr_scanned++;
>  
> -		if (PageWriteback(page))
> -			goto keep_locked;
> +		may_enter_fs = (sc->gfp_mask & __GFP_FS) ||
> +			(PageSwapCache(page) && (sc->gfp_mask & __GFP_IO));
> +
> +		if (PageWriteback(page)) {
> +			if (sync_writeback == PAGEOUT_IO_SYNC && may_enter_fs)
> +				wait_on_page_writeback(page);
> +			else
> +				goto keep_locked;
> +		}

this bit could do with a comment explaining the design decisions, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] synchronous lumpy: improve commentary on writeback wait
    • From: Andy Whitcroft <[email protected]>

• References:
  • [PATCH 0/2] Synchronous Lumpy Reclaim V3
    • From: Andy Whitcroft <[email protected]>
  • [PATCH 2/2] wait for page writeback when directly reclaiming contiguous areas
    • From: Andy Whitcroft <[email protected]>

• Prev by Date: Re: OOPS in shrink_dcache_for_umount
• Next by Date: Re: [PATCH 00/10] foundations for reserve-based allocation
• Previous by thread: [PATCH 2/2] wait for page writeback when directly reclaiming contiguous areas
• Next by thread: [PATCH] synchronous lumpy: improve commentary on writeback wait
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]