Re: [PATCH 1/2] wait_task_zombie: remove unneeded child->signal check

On 08/05, Roland McGrath wrote:
>
> > A zombie must have a valid ->signal, we are going to release it and
> > __exit_signal() starts with BUG_ON(!sig).
> 
> Yes, this is safe because it's after the EXIT_DEAD check under tasklist_lock.

Yes thanks, the changelog could be better.

We "own" this child (it was us sho set EXIT_DEAD), nobody can release it
including the child itself (it already passed exit_notify()). We could even
drop tasklist, but we need ->parent->sighand->siglock.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/2] wait_task_zombie: remove unneeded child->signal check
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/2] wait_task_zombie: remove unneeded child->signal check
    • From: Roland McGrath <[email protected]>

• Prev by Date: Re: [PATCH 4/5] UML - Simplify helper stack handling
• Next by Date: Re: [PATCH 00/23] per device dirty throttling -v8
• Previous by thread: Re: [PATCH 1/2] wait_task_zombie: remove unneeded child->signal check
• Next by thread: [PATCH 2/2] wait_task_zombie: fix 2/3 races vs forget_original_parent()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]