Re: Oops in 2.6.23-rc1-git9, arch/x86_64/pci/k8-bus.c::fill_mp_bus_to_cpumask()

[Andi Kleen <ak@suse.de>]

On Saturday 04 August 2007 18:32:22 Andrew Morton wrote:
> On Sat, 4 Aug 2007 11:30:41 +0200 Andi Kleen <ak@suse.de> wrote:
> 
> > On Saturday 04 August 2007 00:50, Andrew Morton wrote:
> > > On Fri, 03 Aug 2007 18:10:03 -0400
> > >
> > > Chuck Ebbert <cebbert@redhat.com> wrote:
> > > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250859
> > > >
> > > > at line 74:
> > > >
> > > > muli@62829:
> > > > muli@62829: 					sd = bus->sysdata;
> > > > muli@62829: 					sd->node = node;   <=====
> > > >
> > > > bus->sysdata is NULL.
> > > >
> > > > Last changed by this hunk of
> > > > "x86-64: introduce struct pci_sysdata to facilitate sharing of
> > > > ->sysdata":
> > 
> > Hmm, will double check. Perhaps Muli's conversion was incomplete.
> 
> hm.
> 
> > > > @@ -67,7 +69,9 @@ fill_mp_bus_to_cpumask(void)
> > > >  						continue;
> > > >  					if (!node_online(node))
> > > >  						node = 0;
> > > > -					bus->sysdata = (void *)node;
> > > > +
> > > > +					sd = bus->sysdata;
> > > > +					sd->node = node;
> > > >  				}
> > > >  			}
> > > >  		}
> > >
> > > Andy keeps trotting out a patch which will probably fix this,
> > 
> > What patch do you mean? I don't have anything sysdata related
> > left over.
> > 
> 
> "pci device ensure sysdata initialised", now at version 4.

Oh what a mess. I think I'll ask Linus to revert the sysdata patch
instead. Clearly the stuff is half-baked

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/