Re: [PATCH] UBI: Don't use signed int as array index before testing if it is negative

On Sat, 2007-08-04 at 01:25 +0200, Jesper Juhl wrote:
> Hi,
> 
> I can't find anything guaranteeing that 'ubi_num' cannot be <0 in 
> drivers/mtd/ubi/kapi.c::ubi_open_volume(), and in fact the code 
> even tests for that and errors out if so. Unfortunately the test 
> for "ubi_num < 0" happens after we've already used 'ubi_num' as 
> an array index - bad thing to do if it is negative.
> This patch moves the test earlier in the function and then moves 
> the indexing using that variable after the check. A bit safer :-) 
> 
> 
> Signed-off-by: Jesper Juhl <[email protected]>

Thanks for the catch, committed to UBI git tree.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] UBI: Don't use signed int as array index before testing if it is negative
  - From: Jesper Juhl <[email protected]>

Prev by Date: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE
Next by Date: Re: renaming kernel devices [was: VIA EPIA EK: strange eth dev numbering]
Previous by thread: [PATCH] UBI: Don't use signed int as array index before testing if it is negative
Next by thread: custom baud rates with serial core
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]