Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION

On Fri, 3 Aug 2007, Rafael J. Wysocki wrote:
>  	depends on PM
> -	depends on !SMP || SUSPEND_SMP_POSSIBLE
> +	depends on SUSPEND_SMP_POSSIBLE || ((BLACKFIN || MIPS || SUPERH || FRV \
> +		    || (PPC32 && PPC_MPC52xx)) && !SMP)

Please, do that as SUSPEND_UP_POSSIBLE, and make it look like

	config SUSPEND_UP_POSSIBLE
		depends on BLACKFIN || MIPS || SUPERH || FRV || ((PPC32 && PPC_MPC52xx)
		depends on !SMP
		default y

and now you can write the above thing as

	depends on SUSPEND_SMP_POSSIBLE || SUSPEND_UP_POSSIBLE

and it's all much nicer.

I would say that doing a similar setup for HIBERNATE would be nice too, 
but the SUSPEND case is more noticeable because the SMP case is so nice 
already.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
    • From: "Rafael J. Wysocki" <[email protected]>

• References:
  • [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
    • From: "Rafael J. Wysocki" <[email protected]>

• Prev by Date: Re: [PATCH] kill an obsolete sub-thread-ptrace stuff
• Next by Date: Re: [PATCH] Apply memory policies to top two highest zones when highest zone is ZONE_MOVABLE
• Previous by thread: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
• Next by thread: Re: [PATCH] PM: Fix dependencies of CONFIG_SUSPEND and CONFIG_HIBERNATION
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]