Re: [PATCH] RT: Add priority-queuing and priority-inheritance to workqueue infrastructure

[Oleg Nesterov <oleg@tv-sign.ru>]

On 08/02, Oleg Nesterov wrote:
>
> And I don't understand why rt_mutex_setprio() is called just before
> calling work->func(). This means that a high-priority work could
> be delayed by the low-priority ->current_work.

Aha, I missed the rt_mutex_setprio() in insert_work().

This is not good either. Suppose we have

	void work_handler(struct work_struct *self)
	{
		if (!try_lock()) {
			// try again later...
			queue_work(wq, self);
			return;
		}

		do_the_work();
	}

What if that work was queued by the low-priority thread, and
then a high-priority thread inserts a new work when work_handler()
is running?

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/