Re: [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end_io.

[Tejun Heo <htejun@gmail.com>]

NeilBrown wrote:
> As bi_end_io is only called once when the reqeust is compelte,
> the 'size' argument is now redundant.  Remove it.
> 
> Now there is no need for bio_endio to subtract the size completed
> from bi_size.  So don't do that either.
> 
> While we are at it, change bi_end_io to return void.
> 
> Signed-off-by: Neil Brown <neilb@suse.de>
> 
> @@ -538,14 +538,10 @@ static int flush_dry_bio_endio(struct bi
>  
>  	/* Reset bio */
>  	set_bit(BIO_UPTODATE, &bio->bi_flags);
> -	bio->bi_size = bytes;
> -	bio->bi_sector -= (bytes >> 9);
> -
> -	return 0;
>  }

Please adjust comment together.  Just keeping /* Reset bio */ and
killing the comment above it should be enough.  Other than that, nice
clean up!

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/