Re: [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end_io.

NeilBrown wrote:
> As bi_end_io is only called once when the reqeust is compelte,
> the 'size' argument is now redundant.  Remove it.
> 
> Now there is no need for bio_endio to subtract the size completed
> from bi_size.  So don't do that either.
> 
> While we are at it, change bi_end_io to return void.
> 
> Signed-off-by: Neil Brown <[email protected]>
> 
> @@ -538,14 +538,10 @@ static int flush_dry_bio_endio(struct bi
>  
>  	/* Reset bio */
>  	set_bit(BIO_UPTODATE, &bio->bi_flags);
> -	bio->bi_size = bytes;
> -	bio->bi_sector -= (bytes >> 9);
> -
> -	return 0;
>  }

Please adjust comment together.  Just keeping /* Reset bio */ and
killing the comment above it should be enough.  Other than that, nice
clean up!

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 000 of 35] Refactor block layer to improve support for stacked devices.
    • From: NeilBrown <[email protected]>
  • [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end_io.
    • From: NeilBrown <[email protected]>

• Prev by Date: [RFC][PATCH] Coding style fix drivers/scsi/mvme147.c
• Next by Date: Re: [RFC][PATCH] Coding style fix drivers/scsi/aha1542.c
• Previous by thread: [PATCH 007 of 35] Drop 'size' argument from bio_endio and bi_end_io.
• Next by thread: [PATCH 008 of 35] Introduce bi_iocnt to count requests sharing the one bio.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]