Re: [PATCH 2/3] sound/pci ioremap/iounmap balancing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 01 Aug 2007 06:38:16 -0400 Takashi Iwai <[email protected]> 
wrote:
>This would be rater a lacking check of returned errors.
>
>The other changes look incorrect.  All these drivers use
>card->private_free callback to release the resources even for the
>error exit.  Thus, you don't need iounmap in each place.
>
>
>thanks,
>
>Takashi


Missed the callback on the audit, will repost this patch 
(sound/pci) with just the unchecked returns...

---------------------------------------
Scott Thompson / [email protected]
---------------------------------------

--
Click for free information on attaining an equity line of credit.
http://tagline.hushmail.com/fc/Ioyw6h4d9K1rpVNolPplpaj6Tmr87LwpU4yqszBO6uxXkrRlUIHweI/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux