Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

On Wednesday August 1, [email protected] wrote:
> 
> The other issue is with the layered IO design - no matter what we
> configure the stack size to, it is still possible to create a set of
> translation layers that will cause it to crash regularly:  XFS on
> dm_crypt on loop on XFS on dm_crypt on loop on ad infinitum.

No, this does not use indefinite stack.

loop will schedule each request to be handled by a kernel thread, so
requests to 'loop' are serialised, never stacked.

In 2.6.22, generic_make_request detects and serialises recursive calls,
so unlimited recursion is not possible there either.

It is still possible to do
  dm on dm on dm on dm on md on md on md on md

and calls to ->issue_flush_fn or ->unplug_fn could use an arbitrarily
large amount of stack.  But the stack usage of each stage is very
small so it is unlikely to be a problem (though it should still be
fixed).

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: "Dan Merillat" <[email protected]>

• References:
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Rene Herman <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Alan Cox <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Andrea Arcangeli <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Matt Mackall <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Andrea Arcangeli <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Alan Cox <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Eric Sandeen <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Alan Cox <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: "Satyam Sharma" <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: Eric Sandeen <[email protected]>
  • Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
    • From: "Dan Merillat" <[email protected]>

• Prev by Date: Re: Reboot hang FIXED
• Next by Date: Re: [patch] add kdump_after_notifier
• Previous by thread: Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
• Next by thread: Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]