Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver

On Tue, 2007-07-31 at 11:13 +0800, Huang, Ying wrote:

> +
> +#include <linux/delay.h>
> +#include <linux/errno.h>
> +#include <linux/fb.h>
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/ioport.h>
> +#include <linux/mm.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/screen_info.h>
> +#include <linux/slab.h>
> +#include <linux/string.h>
> +#include <linux/dmi.h>
> +#include <linux/efi.h>
> +#include <linux/io.h>
> +
> +#include <video/vga.h>
> +

I don't see any problems with this driver, just a few minor nits.

Do you really need all the #include's?
I presume this driver only supports bpp 16 and above?

Tony



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver
    • From: "Huang, Ying" <[email protected]>

• References:
  • [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver
    • From: "Huang, Ying" <[email protected]>

• Prev by Date: Re: eurotechwdt will cause reboot
• Next by Date: Re: [PATCH] documentation fixes
• Previous by thread: Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver
• Next by thread: Re: [PATCH 4/5] x86_64 EFI support -v3: EFI framebuffer driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]