Re: [PATCH 34] fs/autofs4/inode.c: kmalloc + memset conversion to kzalloc

On Tue, 2007-07-31 at 20:05 +0200, Mariusz Kozlowski wrote:
> Signed-off-by: Mariusz Kozlowski <[email protected]>

ACK.

> 
>  fs/autofs4/inode.c | 10467 -> 10435 (-32 bytes)
>  fs/autofs4/inode.o | 98576 -> 98552 (-24 bytes)
> 
>  fs/autofs4/inode.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- linux-2.6.23-rc1-mm1-a/fs/autofs4/inode.c	2007-07-26 13:07:46.000000000 +0200
> +++ linux-2.6.23-rc1-mm1-b/fs/autofs4/inode.c	2007-07-29 23:56:08.000000000 +0200
> @@ -312,13 +312,11 @@ int autofs4_fill_super(struct super_bloc
>  	struct autofs_sb_info *sbi;
>  	struct autofs_info *ino;
> 
> -	sbi = kmalloc(sizeof(*sbi), GFP_KERNEL);
> +	sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
>  	if (!sbi)
>  		goto fail_unlock;
>  	DPRINTK("starting up, sbi = %p",sbi);
> 
> -	memset(sbi, 0, sizeof(*sbi));
> -
>  	s->s_fs_info = sbi;
>  	sbi->magic = AUTOFS_SBI_MAGIC;
>  	sbi->pipefd = -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [KJ PATCHES] mostly kmalloc + memset conversion to k[cz]alloc
    • From: Mariusz Kozlowski <[email protected]>
  • [PATCH 34] fs/autofs4/inode.c: kmalloc + memset conversion to kzalloc
    • From: Mariusz Kozlowski <[email protected]>

• Prev by Date: Re: WARN_ON() which sometimes sucks
• Next by Date: Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem.
• Previous by thread: [PATCH 34] fs/autofs4/inode.c: kmalloc + memset conversion to kzalloc
• Next by thread: [PATCH 35] fs/reiser4/plugin/inode_ops_rename.c: kmalloc + memset conversion to kzalloc
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]