Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal

* Oleg Nesterov ([email protected]) wrote:
> > I am not sure. This means we restart sys_poll() with the same timeout
> > if there is no pending signal. I think we need ERESTART_RESTARTBLOCK
> > logic.
> 
> Forgot to mention, sys_select() can use ERESTARTNOHAND because it
> modifies "struct timeval __user *tvp" before return, but sys_poll()
> gets timeout_msecs by value.

Yeah, you're right.  Means sys_poll with STOP/CONT cycles going in
background (and no fds ready) would never return.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
    • From: Manfred Spraul <[email protected]>
  • Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: [PATCH 21] drivers/scsi/dpt_i2o.c: kmalloc + memset conversion to kzalloc
• Next by Date: [PATCH 22] drivers/net/e1000new/ethtool.c: kmalloc + memset conversion to kzalloc
• Previous by thread: Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
• Next by thread: Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]