Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch.

On 07/31/2007 02:53 PM, [email protected] wrote:

-	desc_base = (u32)kmalloc(entries * sizeof(au1x_ddma_desc_t),
+	desc_base = kmalloc(entries * sizeof(au1x_ddma_desc_t),

The unnessary bit in kmalloc casts is due to void pointers being assignment compatible to other pointer types but in these patches you are also removing casts to unsigned long's and they should stay.

I noticed the same in patch 2, 4, 6, 8, 9 and 11 (cursory glance...)

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch 00/16] Remove unnecessary kmalloc casts
    • From: [email protected]
  • [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch.
    • From: [email protected]

• Prev by Date: RE: Time Problems with 2.6.23-rc1-gf695baf2
• Next by Date: Re: [PATCH 000 of 35] Refactor block layer to improve support for stacked devices.
• Previous by thread: Re: [Patch 02/16] Remove unnecessary kmalloc casts from the mips arch.
• Next by thread: [PATCH 0/2][RFC] VFCIPI v3
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]