Signed-off-by: Matthew Dharm <[email protected]> On Tue, Jul 31, 2007 at 12:28:22AM +0200, Adrian Bunk wrote: > The Coverity checker spotted that we have already oops'ed if "us" > was NULL. > > Since "us" can't be NULL in the only caller this patch removes the > NULL check. > > Signed-off-by: Adrian Bunk <[email protected]> > > --- > --- linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c.old 2007-07-30 16:56:34.000000000 +0200 > +++ linux-2.6.23-rc1-mm1/drivers/usb/storage/shuttle_usbat.c 2007-07-30 16:57:24.000000000 +0200 > @@ -190,9 +190,6 @@ static int usbat_check_status(struct us_ > unsigned char *reply = us->iobuf; > int rc; > > - if (!us) > - return USB_STOR_TRANSPORT_ERROR; > - > rc = usbat_get_status(us, reply); > if (rc != USB_STOR_XFER_GOOD) > return USB_STOR_TRANSPORT_FAILED; -- Matthew Dharm Home: [email protected] Maintainer, Linux USB Mass Storage Driver I need a computer? -- Customer User Friendly, 2/19/1998
Attachment:
pgpCltwFwhGVz.pgp
Description: PGP signature
- References:
- [2.6 patch] usbat_check_status(): fix check-after-use
- From: Adrian Bunk <[email protected]>
- [2.6 patch] usbat_check_status(): fix check-after-use
- Prev by Date: Re: [PATCH] add check do_direct_IO() return val
- Next by Date: Re: [2.6 patch] make pktgen.c:get_ipsec_sa() static and non-inline
- Previous by thread: [2.6 patch] usbat_check_status(): fix check-after-use
- Next by thread: regression on HP zx1 platform from ACPI autoload modules patches
- Index(es):
 |