Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal

* Andrew Morton ([email protected]) wrote:
> On Sun, 29 Jul 2007 19:05:05 +0200 Manfred Spraul <[email protected]> wrote:
> > poll() returns -EINTR if a signal is pending.
> > EINTR is a bad choice: it means that poll returns to user space if the
> > task is stopped by SIGSTOP/SIGCONT or by the freezer.
> > select() and ppoll() both use ERESTARTNOHAND, this avoids a return to
> > user space for signals that are handled by the kernel.
> > 
> > The patch switches poll() to ERESTARTNOHAND.
> > Tested with FC6. Patch against 2.6.23-rc1-mm1.
> 
> hm.  Is this a fix against
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/broken-out/do_poll-return-eintr-when-signalled.patch
> only, or does mainline also need fixing?

Mainline has same issue (although fix is certainly a bit different w/out
Oleg's patch).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
  - From: Manfred Spraul <[email protected]>
- Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
  - From: Andrew Morton <[email protected]>

Prev by Date: Re: [PATCH] CPU online file permission
Next by Date: Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic
Previous by thread: Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
Next by thread: Re: [PATCH] Use ERESTARTNOHAND if poll() is interrupted by a signal
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]